Fix a few examples in docs that are not 2.19 compatible #2581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraNod
added
the
backport-2.19
gotmax23
approved these changes
Apr 29, 2025
samccann
approved these changes
May 6, 2025
|
@sivel - Should these be backported to other releases so we are showing the correct content in 2.16-2.18 as well? |
|
I'm not sure I would backport in it's entirety, which I suppose also means I'd be fine not backporting. If we did backport, I think only:
The other changes should stay in the older branches. |
Backport to stable-2.19: 💚 backport PR created✅ Backport PR branch: Backported as #2629 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 12, 2025
* Fix a few examples in docs that are not 2.19 compatible * remove finalize example of None -> empty string * A few assert cleanups (cherry picked from commit 6a3a90c)
felixfontein
pushed a commit
that referenced
this pull request
May 12, 2025
* Fix a few examples in docs that are not 2.19 compatible * remove finalize example of None -> empty string * A few assert cleanups (cherry picked from commit 6a3a90c) Co-authored-by: Matt Martz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few examples in docs that are not 2.19 compatible